FpML Issues Tracker

697: consistency of “if then else”

May 14, 2008

closed

Minor

Always

Validation Rules

Admin

None

Summary

The structure "if then else" should be applied consistently. At the moment three rules deviate from this and use "if then otherwise".

All rules should use "if then else" consistently.

The rules to fix are:

Searching for: otherwise rules-english-ird.xml(17): The regular period of a set of calculation period dates is the period between a start date and an end date. The start date is firstRegularPeriodStartDate, if present, or effectiveDate/unadjustedDate otherwise. The end date is lastRegularPeriodEndDate, if present, or terminationDate/unadjustedDate otherwise. rules-english-ird.xml(169): This rule applies when calculationPeriodFrequency/rollConvention is a number. Let the start date be firstRegularPeriodStartDate if it exists, or effectiveDate/unadjustedDate otherwise: If calculationPeriodFrequency/rollConvention is less than or equal to the last day of the month in the start date, then the day of the start date must match it. Otherwise the day of the start date must be the last day of the month of that date. rules-english-ird.xml(185): This rule applies when calculationPeriodFrequency/rollConvention is a number. Let the end date be lastRegularPeriodEndDate if it exists, or terminationDate/unadjustedDate otherwise: If calculationPeriodFrequency/rollConvention is less than or equal to the last day of the month in the end date, then the day of the end date must match it. Otherwise the day of the end date must be the last day of the month of that date. Found 3 occurrence(s) in 1 file(s)

Notes:

  • matthewdr

    06/03/08 1:51 pm

    Agreed at VWG. Marc Gratacos to implement.

  • mgratacos

    06/03/08 1:52 pm

    If…Then…Otherwise should be replaced by If…Then…Else

  • lyteck

    06/03/08 4:35 pm

    As per Val WG agreement (6/03/08), corrected usage of “if then otherwise” to “if then else” (3 instances)

  • h_mcallister

    06/04/08 8:24 am

    Please publish the justification for use of if .. then .. else, rather than if .. then .. otherwise.

  • h_mcallister

    06/05/08 8:00 pm

    Please publish the rationale for imposing an “if .. then .. else” structure on all rules

  • lyteck

    08/18/08 2:54 pm

    As discussed at the Validation WG 2008-08-12: The majority of
    conditional constructs were already expressed using “if then else”. There were only 3 occurences of “if then otherwise” which have been changed for consistency.

  • matthewdr

    08/19/08 5:06 pm

    Closed after testing resolution.

  • Leave an update

    You must be logged in to post an update.